Repository navigation
RAT-581: Check license headers in Rust source files - #753
Merged
Claudenw merged 2 commits intoOct 19, 2026
Merged
Conversation
ottlinger
changed the title
Claudenw
approved these changes
Oct 19, 2026
Claudenw
left a comment
Claudenw
left a comment
Contributor
There was a problem hiding this comment.
LGTM
@tisonkun Thank you for your contribution.
@ottlinger This change is restricted to the core code and so does not impact the UI work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust
.rssource files are reported asBINARYbecause Tika identifies them asapplication/rls-services+xml, which RAT does not map to a text document. As a result, neither approved headers nor missing or unapproved licenses are checked.Classify this XML media type as
STANDARD, following the existing XML mappings and the approach used for XSLT in #658. Content detection still takes precedence: a PNG named.rsremains binary. Add analyzer-level regression tests for Apache, GPL, unknown and missing Rust license headers, actual RLS XML, and a renamed PNG.The separate Tika filename ambiguity is tracked in TIKA-4977.
Validation:
BINARY; the renamed PNG test passes../mvnw -B -ntp clean installpasses with JDK 25.0.2 and Maven 3.10.0.