Repository navigation
RAT: write the ORCA data and Makefile entries as excludes - #2225
Merged
Merged
Conversation
Jean-Baptiste Onofre noted in the 2.2.0-incubating-rc3 IPMC vote that the RAT configuration in pom.xml has two <include> elements, which is confusing. They sit inside <excludes>, and Maven ignores the element names of list items, so they have always acted as excludes: ORCA's DXL test data under src/backend/gporca/data and its Makefiles carry no license header and are left out of the audit. Write them as <exclude> so the configuration says what it does. The RAT result is unchanged. Assisted-by: Claude Code
Member
Author
Member
Author
|
For main: #2226 |
reshke
approved these changes
Nov 2, 2026
leborchuk
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jean-Baptiste Onofre noted in the 2.2.0-incubating-rc3 IPMC vote that the RAT configuration in pom.xml has two
<include>elements, which is confusing. They sit inside<excludes>, and Maven ignores the element names of list items, so they have always acted as excludes: ORCA's DXL test data undersrc/backend/gporca/dataand its Makefiles carry no license header and are left out of the audit.Write them as
<exclude>so the configuration says what it does. The RAT result is unchanged.Assisted-by: Claude Code
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions