Repository navigation
License: list the Bison-generated orafce parser - #2162
Merged
Merged
Conversation
gpcontrib/orafce/sqlparse.c and sqlparse.h are generated by GNU Bison 3.7.4 and ship with upstream orafce. They carry the Bison skeleton's GPL-3.0-or-later notice with the Bison special exception, so a reviewer scanning for GPL text finds them, but LICENSE did not explain them. The ASF settled this case in LEGAL-291: the exception lets the generated parser be distributed under terms of the distributor's choice, so it is distributed under the Apache License and needs no LICENSE or NOTICE entry. The build-tools allowance in resolved.html does not name Bison, so LEGAL-291, not that allowance, is the basis. List the two files at the end of the build system section, with their copyright line and that basis, and retitle the section to cover them. Assisted-by: Claude Code
leborchuk
approved these changes
Oct 21, 2026
MisterRaindrop
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gpcontrib/orafce/sqlparse.c and sqlparse.h are generated by GNU Bison 3.7.4 and ship with upstream orafce. They carry the Bison skeleton's GPL-3.0-or-later notice with the Bison special exception, so a reviewer scanning for GPL text finds them, but LICENSE did not explain them.
The ASF settled this case in LEGAL-291: the exception lets the generated parser be distributed under terms of the distributor's choice, so it is distributed under the Apache License and needs no LICENSE or NOTICE entry. The build-tools allowance in resolved.html does not name Bison, so LEGAL-291, not that allowance, is the basis.
List the two files at the end of the build system section, with their copyright line and that basis, and retitle the section to cover them.
Assisted-by: Claude Code
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions