Repository navigation
Conversation
On Ubuntu 26.04, "make installcheck-good" and "installcheck-cbdb-parallel" stop before any test runs: scanning for flaky fault-injection tests... comm: file 1 is not in sorted order comm: input is not in sorted order make: *** [GNUmakefile:213: installcheck-good] Error 1 Ubuntu 26.04 replaces GNU coreutils with uutils coreutils. In the UTF-8 locale of the build images (en_US.UTF-8), its sort -u and comm do not agree on the order of the two test lists, so comm rejects its input. GNU coreutils 9.4 on Ubuntu 24.04 does not have this problem. Make sort and comm use the same order by running the script in the C locale. The test names are ASCII, so only the collation changes. Checked on Ubuntu 26.04 in the build image: the script fails in the default locale and passes with LC_ALL=C. It passes in both ways on Ubuntu 24.04. Assisted-by: Claude Code Backpatch-through: REL_2_STABLE
Member
Author
|
This change has been verified in Ubuntu 26.04 on #2096 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Ubuntu 26.04, "make installcheck-good" and "installcheck-cbdb-parallel" stop before any test runs:
Ubuntu 26.04 replaces GNU coreutils with uutils coreutils. In the UTF-8 locale of the build images (en_US.UTF-8), its sort -u and comm do not agree on the order of the two test lists, so comm rejects its input. GNU coreutils 9.4 on Ubuntu 24.04 does not have this problem.
Make sort and comm use the same order by running the script in the C locale. The test names are ASCII, so only the collation changes.
Checked on Ubuntu 26.04 in the build image: the script fails in the default locale and passes with LC_ALL=C. It passes in both ways on Ubuntu 24.04.
Assisted-by: Claude Code
Backpatch-through: REL_2_STABLE
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions