Repository navigation
Conversation
Python 3.12 and later warn at compile time about a backslash that is not a valid escape sequence in a normal string, and the warning is printed every time such a script is run: mocker.py:245: SyntaxWarning: "\[" is an invalid escape sequence. Such sequences will not work in the future. Did you mean "\\["? The warning of mocker.py is printed about sixty times in a unittest-check run, once for every test directory, and the ones of contrib/try_convert/scripts show up in the "make installcheck" of the contrib modules. The warning is the same on Ubuntu 24.04 and 26.04. Double the backslash of each invalid escape sequence, which gives the same string value as before, in 12 files: mocker.py, gpcheckperf, gpmemreport, gpssh-exkeys, two scripts in src/backend/gporca/scripts and the scripts in contrib/try_convert/scripts. Checked for each file that the syntax tree of the new source is the same as the one of the old source, which means every string has the same value, and that the file compiles without a warning. No Python file in the repository has an invalid escape sequence now. Assisted-by: Claude Code Backpatch-through: REL_2_STABLE
Member
Author
|
This change has been verified in Ubuntu 26.04 on #2096 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.12 and later warn at compile time about a backslash that is not a valid escape sequence in a normal string, and the warning is printed every time such a script is run:
mocker.py:245: SyntaxWarning: "[" is an invalid escape sequence.
Such sequences will not work in the future. Did you mean "\["?
The warning of mocker.py is printed about sixty times in a unittest-check run, once for every test directory, and the ones of contrib/try_convert/scripts show up in the "make installcheck" of the contrib modules. The warning is the same on Ubuntu 24.04 and 26.04.
Double the backslash of each invalid escape sequence, which gives the same string value as before, in 12 files: mocker.py, gpcheckperf, gpmemreport, gpssh-exkeys, two scripts in src/backend/gporca/scripts and the scripts in contrib/try_convert/scripts.
Checked for each file that the syntax tree of the new source is the same as the one of the old source, which means every string has the same value, and that the file compiles without a warning. No Python file in the repository has an invalid escape sequence now.
Assisted-by: Claude Code
Backpatch-through: REL_2_STABLE
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions