Conversation
Four third-party components that are compiled into and shipped with
Cloudberry were never registered in the root LICENSE file:
- gpcontrib/pg_hint_plan/* BSD 3-Clause (NTT)
- gpMgmt/bin/lib/pexpect/__init__.py ISC (Noah Spurrier)
gpMgmt/bin/lib/pexpect/pxssh.py
- gpcontrib/gpcloud/lib/http_parser.* MIT (Joyent / NGINX)
- gpcontrib/gpcloud/lib/ini.* MIT (rxi)
All four arrived with the Greenplum code base, so they are registered
under the existing "The Greenplum Database software includes" section.
Their upstream license texts are added under licenses/, copied from the
files themselves (pg_hint_plan from its own COPYRIGHT file).
The pexpect entry deliberately names the two upstream files rather than
using a gpMgmt/bin/lib/pexpect/* wildcard: the third file in that
directory, Makefile, is our own build glue and is not under the pexpect
license. gpcontrib/pg_hint_plan/ is a pristine upstream subtree with no
project-authored files, so a wildcard is accurate there.
Note that pom.xml already carries a dedicated Apache RAT matcher for
rxi's ini ("MIT (RXI-derived)"), so the component was known to the audit
tooling but had never been reflected in LICENSE.
Two stale or malformed paths found while auditing every path referenced
by LICENSE are corrected here as well:
- dependencies/yyjson does not exist; the directory is dependency/yyjson
- a stray trailing colon after src/pl/plperl/ppport.h
Verified with `mvn clean verify -Drat.consoleOutput=true` on Rocky 9:
Unapproved: 0, unknown: 0, generated: 1, approved: 5657 licenses.
Assisted-by: Claude Code
Backpatch-through: REL_2_STABLE
PostgreSQL renamed src/port/gettimeofday.c to src/port/win32gettimeofday.c, so the path LICENSE points at for the PostgreSQL-style license entry no longer exists on this branch. Point it at the new name; licenses/LICENSE-gettimeofday.txt still matches the header of the renamed file verbatim, so only the path changes. Not applicable to REL_2_STABLE, which is still on the PostgreSQL 14 base where src/port/gettimeofday.c exists under its original name. Note that the surrounding context is identical on both branches, so this hunk would apply cleanly there and silently introduce a dangling path -- it is kept as a separate commit so that the preceding LICENSE fix can be backpatched on its own. Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions