fix SetHostSocket when add stream failed#3386
Open
lo-tk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: introduced by PR #2938 .
Problem Summary:
Stream::SetHostSocket performs host-socket binding inside std::call_once, which makes the first execution result effectively global for all later callers. If AddStream(id()) fails during that first attempt, the lambda returns without setting _host_socket, but the once_flag is still consumed. After that, subsequent callers cannot retry the binding logic and may only observe the post-state through the function return value. This creates a broken state where the stream is not actually attached to any host socket, while later code paths still assume the binding has succeeded, eventually triggering _host_socket == NULL checks or null-dereference style crashes.
Changed:
return _host_socket != NULL ? 0 : -1;
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: