GH-51116: [C++] Update bundled Boost - #51132
Conversation
|
|
There was a problem hiding this comment.
🟢 Approval recommended
The version/hash updates are consistent across the CMake toolchain and Meson wrap inputs, with no remaining mismatches found in the changed configuration.
Pull request overview
Updates Arrow C++’s bundled Boost dependency to 1.92.0, aligning the third-party version metadata and build inputs to pick up upstream fixes referenced in the linked issues.
Changes:
- Bump bundled Boost version/checksum to 1.92.0 in the third-party versions registry.
- Update the Meson wrap definition to download Boost 1.92.0 with the matching hash.
- Extend CMake’s
Boost_ADDITIONAL_VERSIONSlist to recognize newer Boost releases (1.90–1.92) when using FindBoost.
File summaries
| File | Description |
|---|---|
| cpp/thirdparty/versions.txt | Updates Boost version and SHA256 used by Arrow’s thirdparty toolchain. |
| cpp/subprojects/boost.wrap | Updates Meson wrap download URL/hash/directory for Boost 1.92.0. |
| cpp/cmake_modules/ThirdpartyToolchain.cmake | Adds Boost 1.90–1.92 entries to Boost_ADDITIONAL_VERSIONS for CMake discovery. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Revision: b75157f Submitted crossbow builds: ursacomputing/crossbow @ actions-75e80bae0f |
|
@github-actions crossbow submit -g cpp -g r -g python -g example-cpp |
|
Revision: b75157f Submitted crossbow builds: ursacomputing/crossbow @ actions-ced955448b |
raulcd
left a comment
There was a problem hiding this comment.
Thanks for working on this! Some of the failures doesn't seem to happen on the latest nightlies, could you rebase main to validate them?
I'll kick off the Linux packaging jobs to validate after that.
b75157f to
6aa45a3
Compare
|
@raulcd Thank you for your reply. I have rebased main. |
There was a problem hiding this comment.
🔵 Needs a closer look
Updating a bundled dependency can have broad, platform-specific build/runtime impacts that can’t be fully validated from the diff alone.
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
|
@github-actions crossbow submit -g nightly-tests |
|
Revision: 6aa45a3 Submitted crossbow builds: ursacomputing/crossbow @ actions-c46f68adf9 |
Rationale for this change
The latest version of boost is 1.92.0. It fixes some bugs in the version used now. See #50978
What changes are included in this PR?
Update boost.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.