fix(arrow/extensions): reject Null Variant typed_value - #1243
Open
dgvj-work wants to merge 1 commit into
Open
Conversation
A Null typed_value column is not a valid shredded type. Variant nulls belong in the value column. Fixes apache#1205 Signed-off-by: Digvijay <digvijay.vaghela@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
A Null
typed_valuecolumn is not a valid shredded Variant type. Nulls are encoded in thevaluecolumn as Variant null (00). A dedicated Nulltyped_valuewould also make “field present and null” indistinguishable from “field missing” for shredded objects.See apache/arrow#50622 and apache/arrow#50810.
Fixes #1205
What changes are included in this PR?
NewVariantTyperejects a Nulltyped_valuefieldtyped_valueare also rejectedAre these changes tested?
go test ./arrow/extensionsAre there any user-facing changes?
Yes — constructing a Variant extension type with a Null
typed_valuenow returnsarrow.ErrInvalid.