fix(parquet/pqarrow): require Variant value field when writing - #1242
Open
dgvj-work wants to merge 1 commit into
Open
fix(parquet/pqarrow): require Variant value field when writing#1242dgvj-work wants to merge 1 commit into
dgvj-work wants to merge 1 commit into
Conversation
Parquet writers must include the Variant value column. Reading files that omit it stays allowed for compatibility. Fixes apache#1204 Signed-off-by: Digvijay <digvijay.vaghela@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Consensus in apache/parquet-format#591 is that the Variant
valuefield is mandatory for writers. arrow-go currently omits it when a shredded schema has onlymetadata+typed_value.Reading files that already omit
valueshould still work.Fixes #1204
What changes are included in this PR?
ToParqueterrors if a Variant extension type has novaluefieldFromParquetstill accepts Variant groups withoutvalueAre these changes tested?
go test ./parquet/pqarrow -run 'TestVariantValueRequiredOnWrite|TestReadVariantWithoutValueField|TestConvertSchemaParquetVariant|TestShreddedVariantSchema'Are there any user-facing changes?
Yes — writing a Variant schema without a
valuefield now returnsarrow.ErrInvalid. Reading such files is unchanged.