[Hotfix] Change log4j impl dependency to log4j-slf4j2-impl - #4336
Open
zhoujinsong wants to merge 5 commits into
Open
[Hotfix] Change log4j impl dependency to log4j-slf4j2-impl#4336zhoujinsong wants to merge 5 commits into
log4j-slf4j2-impl#4336zhoujinsong wants to merge 5 commits into
Conversation
github-actions
Bot
added
module:ams-server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
PR #4046 upgraded
slf4j-apifrom1.7.xto2.0.17, but did not update the Log4j2 binding accordingly.log4j-slf4j-impluses the StaticLoggerBinder mechanism, which is only compatible with SLF4J 1.7.x. SLF4J 2.x uses ServiceLoader to discover providers, and sincelog4j-slf4j-impldoes not register as aSLF4JServiceProvider, SLF4J falls back to a NOP (no-operation) logger.This PR changes the impl to
log4j-slf4j2-implto match the newslf4j-api.Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation