[AMORO] Fix SLF4J 2.x logging not working due to incompatible log4j-slf4j-impl binding - #4335
Open
felixhzhu wants to merge 2 commits into
Open
[AMORO] Fix SLF4J 2.x logging not working due to incompatible log4j-slf4j-impl binding#4335felixhzhu wants to merge 2 commits into
felixhzhu wants to merge 2 commits into
Conversation
github-actions
Bot
added
module:mixed-flink
felixhzhu
force-pushed
the
fix-slf4j2-logging-provider
branch
from
August 24, 2026 08:27
65ed30c to
6c2566e
Compare
github-actions
Bot
removed
module:mixed-flink
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace log4j-slf4j-impl with log4j-slf4j2-impl across all modules.
Why
PR #4046 upgraded slf4j-api from 1.7.x to 2.0.17, but did not update the Log4j2 binding accordingly. log4j-slf4j-impl uses the StaticLoggerBinder mechanism which is only compatible with SLF4J 1.7.x. SLF4J 2.x uses ServiceLoader to discover providers, and since log4j-slf4j-impl does not register as a SLF4JServiceProvider, SLF4J falls back to NOP (no-operation) logger.
This results in zero log output in amoro-optimizer (and potentially other modules depending on classpath order).
Fix
log4j-slf4j2-impl is the correct Log4j2 → SLF4J 2.x bridge that implements SLF4JServiceProvider.
How to verify
Build amoro-optimizer-standalone
Run optimizer — previously showed No SLF4J providers were found, now shows normal Log4j2 output