This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Disable ssl test for staging server if current classpath contains the jetty shaded classes - #573
Open
echarles wants to merge 6 commits into
Conversation
… jetty shaded classes
echarles
force-pushed
the
jetty-sslcontext
branch
from
January 8, 2018 10:05
098175e to
d3bdf0c
Compare
mccheah
reviewed
Jan 9, 2018
| } | ||
|
|
||
| try { | ||
| Class.forName("org.spark_project.jetty.util.ssl.SslContextFactory") |
There was a problem hiding this comment.
use Utils.classForName, it's the reason why Jenkins is failing the build here.
Member
Author
|
@mccheah I have pushed an update using |
Member
Author
|
@mccheah build is |
Member
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
ResourceStagingServerSuite.Enable SSL on the serverwill will run only if the current classpath does not contain the shaded jetty classes.If you rely on the spark-core.jar in your classpath, this test will not run.
If you rely on the spark-core module (without shading), this test will be run.
This is to address issues discussed in #463.
To allow test with spark-core.jar, we also add the jetty deps in the
kubernetes/corepom (see also #570).How was this patch tested?
Run maven test phase from the local spark/core module or from the top of the spark maven hierarchy.