GO-7383 Drop the root-level v1 proto compatibility mirrors - #15
Merged
Merged
Conversation
The four root .proto paths were deterministic mirrors of format/v1/proto, rendered and verified by format/v1/check-proto-compat.sh. Two complete import graphs for the same package symbols only earned their keep while heart's mirror-any-block.yml workflow wrote to this repository's root; a companion PR there retargets it at format/v1/proto, after which the mirrors have no consumer. Remove the mirrors, the script that rendered them, its go:generate directive, and the CI step that verified them. The checked-in Go bindings and JSON Schemas were already generated from the canonical tree alone, so no generated artifact changes. Also drop docs/, which held two superseded design specs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four root
.protopaths were deterministic mirrors offormat/v1/proto, rendered and verified byformat/v1/check-proto-compat.sh. Maintaining two complete import graphs for the same package symbols only earned its keep whileanytype-heart'smirror-any-block.ymlwrote to this repository's root.anyproto/anytype-heart#3290 retargets that workflow at
format/v1/proto, after which the mirrors have no consumer.Changes
models.proto,events.proto,changes.proto,snapshot.protofrom the rootformat/v1/check-proto-compat.sh, whose only job was rendering and verifying themcheck-proto-compat.sh --writedirective fromformat/v1/generate.goand the "Verify v1 proto compatibility paths" step from CIREADME.mdandformat/v1/README.md, which described the mirror rules and the historical root-path smoke commanddocs/, which held two superseded design specsVerification
go generate ./codec/anyblockjson ./format/v1produces no diff — the checked-in Go bindings and JSON Schemas were already generated from the canonical tree alonego test ./...andgo vet ./...passprotoc -I . format/v1/proto/*.protocompiles the graphMerge order
Merge this before the heart PR. If heart merges first, a mirror run writes only
format/v1/protowhile the root copies remain, and the compat check — still in place until this lands — fails.