GO-7383 Document the cross-space object link in the block text syntax - #13
Merged
Merged
Conversation
The served text for a text block listed the same-space object link only; the platform's two-parameter form (objectId + spaceId) links to an object in another space, kept by the codec as an ordinary link with its param verbatim. The API expands a short space id in it to the full one on write.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The served block-text syntax (
object.schema.json, five text-block slots) listed the same-space object link only. It now also names the platform's two-parameter deep link:INLINE_MARKUP.md's row for that form now calls it the cross-space object link, keeps the rule that a second parameter makes it not-an-object-link here (the codec keeps it as an ordinary link, param verbatim), and notes that the API expands a short space id in it to the full one on write.Why
Round-six eval: at call 48 a served schema handed an agent the block-text syntax and it had no way to reference an object in another space. The link form already exists (
core/block/export/writer.goemits it); only the served text was silent about it.Notes
TestPublishedProse), and the guide row keeps the sentenceTestInlineMarkupGuideMatchesTheParserpins.go-7383-typed-hints-followup, f3789ca70) rewrites a shortspaceIdin such a link to the full id on every path that turns caller text into marks, and bumps to this commit.