Skip to content

feat(maps): 支持自定义高德地图 JS 版本 #2863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lzxue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(maps): 支持自定义高德地图 JS 版本 #2863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/maps/src/amap-next/map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export default class AMapService extends BaseMap<AMap.Map> {
token,
mapInstance,
plugin = [],
version = AMAP_VERSION,

@gemini-code-assist gemini-code-assist Bot Jun 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

在 init 方法中，解构出的局部变量 version 与类属性 this.version（定义在第 39 行 public version = MapType.GAODE;）同名。这会造成变量遮蔽（Shadowing），容易引起混淆并增加维护成本。建议在解构时将其重命名，例如 version: amapVersion。

Suggested change
version = AMAP_VERSION,
version: amapVersion = AMAP_VERSION,

...rest
} = this.config;

Expand All @@ -65,7 +66,7 @@ export default class AMapService extends BaseMap<AMap.Map> {
plugin.push('Map3D');
await AMapLoader.load({
key: amapKey, // 申请好的Web端开发者Key，首次调用 load 时必填
version: AMAP_VERSION, // 指定要加载的 JSAPI 的版本
version: version, // 指定要加载的 JSAPI 的版本

@gemini-code-assist gemini-code-assist Bot Jun 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

配合前面解构时的重命名，这里应将 version 替换为 amapVersion，以避免使用被遮蔽的变量名并保持上下文清晰。

Suggested change
version: version, // 指定要加载的 JSAPI 的版本
version: amapVersion, // 指定要加载 of JSAPI 的版本

plugins: plugin, // 需要使用的的插件列表，如比例尺'AMap.Scale'等
});
}
Expand Down
Loading