Skip to content

fix: comment out .less import to avoid requiring less preprocessor #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lzxue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: comment out .less import to avoid requiring less preprocessor #2851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/component/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import MarkerLayer from './marker-layer';

import './assets/iconfont/iconfont.js';
// 引入样式
import './css/index.less';
// import './css/index.less'; /* 注释掉以避免消费者必须安装 less */

@gemini-code-assist gemini-code-assist Bot Apr 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

建议不要在代码中保留被注释掉的 import 语句（Zombie Code）。这会影响代码的整洁度和可维护性。既然决定不再通过这种方式引入样式，建议直接删除该行，或者将其替换为一段说明文字，告知开发者需要手动引入编译后的 CSS 文件。

Suggested change
// import './css/index.less'; /* 注释掉以避免消费者必须安装 less */
// 样式需由外部手动引入，避免强制消费者安装 less 预处理器


export * from './control/baseControl';
export { ExportImage, type IExportImageControlOption } from './control/exportImage';
Expand Down
Loading