Skip to content

fix: pass preserveDrawingBuffer to Mapbox for screenshot support (#2723) #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lzxue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: pass preserveDrawingBuffer to Mapbox for screenshot support (#2723) #2843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/maps/src/mapbox/map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ export default class MapboxService extends BaseMapService<Map & IMapboxInstance>
token,
rotation = 0,
mapInstance,
preserveDrawingBuffer,
...rest
} = this.config;

Expand Down Expand Up @@ -128,7 +129,7 @@ export default class MapboxService extends BaseMapService<Map & IMapboxInstance>
style: this.getMapStyleValue(style),
attributionControl,
bearing: rotation,
...rest,
preserveDrawingBuffer: preserveDrawingBuffer ?? undefined,

@gemini-code-assist gemini-code-assist Bot Mar 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

在修改中移除了 ...rest 扩展运算符，这会导致 this.config 中原本通过 ...rest 传递给 Mapbox 的其他配置项（如 zoom, center, pitch, antialias 等）丢失，从而导致功能回归。建议在显式传递 preserveDrawingBuffer 的同时保留 ...rest。

        preserveDrawingBuffer: preserveDrawingBuffer ?? undefined,
        ...rest,

});
}
this.map.on('load', () => {
Expand Down
Loading