refactor(sync): remove unused model metadata logic in kilo provider#3235
Open
levdad wants to merge 8 commits into
Open
refactor(sync): remove unused model metadata logic in kilo provider#3235levdad wants to merge 8 commits into
levdad wants to merge 8 commits into
Conversation
Remove unused file system imports, constants, and helper functions (`modelMetadataExists`, `baseModelOmit`, `baseModelOverrides`, etc.) that were previously used for managing model metadata via local TOML files. This cleans up the Kilo sync provider by removing dead code and unnecessary dependencies on `node:fs` and `node:path`.
Contributor
|
No actionable findings. |
Apply consistent code formatting to the Kilo sync provider, including multi-line type imports, Zod schema definitions, and improved line wrapping for complex conditional expressions and function calls.
Ensure that `apiDescription` is explicitly converted to `null` if it is falsy before falling back to `describeModel`. This prevents potential issues with truthiness checks and ensures consistent object structure when the description is missing.
Update the type assertion for `orderedEfforts` in the Kilo provider to use a conditional type check against `SyncedFullModel`. This ensures that the `values` property strictly adheres to the expected type definition of the reasoning options, preventing type mismatches during synchronization.
Contributor
|
No actionable findings. |
Contributor
Author
|
Added a fix for the error when the api returned an empty description for a model, like the error in GitHub Action. @rekram1-node can you have a look at this? |
…hinking variants Update Kilo and OpenRouter providers to recognize and correctly process model IDs ending in `:discounted` and `:thinking`. This ensures these specialized model variants are properly mapped to their canonical base models during the synchronization process.
Adjust the priority of model description resolution to ensure that `apiDescription` is preferred over `existing.description`, while maintaining the fallback to `describeModel` if neither is available.
Contributor
|
No actionable findings. |
Contributor
Author
|
Reordering the description logic to prioritize the provider/API description. Verified in 61cf5c5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused file system imports, constants, and helper functions (
modelMetadataExists,baseModelOmit,baseModelOverrides, etc.) that were previously used for managing model metadata via local TOML files. This cleans up the Kilo sync provider by removing dead code and unnecessary dependencies onnode:fsandnode:path.based on the review of #2997 comment