Skip to content

Fix scroll thomb length changing on cards /tags lists of different size rows on bug #21367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amoniaka-knabino wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Fix scroll thomb length changing on cards /tags lists of different size rows on bug #21367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b894c80
Stabilize browser scrollbar thumb size
amoniaka-knabino Jul 11, 2026
f07f297
Try stabilize scrollbar thumb position
amoniaka-knabino Jul 11, 2026
1366800
refactor
amoniaka-knabino Jul 12, 2026
c3a0afd
add comment
amoniaka-knabino Jul 12, 2026
16fc3ae
add comment to getCachedVisibleItemCount and getCachedHandleHeight funcs
amoniaka-knabino Jul 12, 2026
ffc4693
add comment to getScrollProportion
amoniaka-knabino Jul 12, 2026
83ae672
Switch tags to RecyclerFastScroller
amoniaka-knabino Jul 12, 2026
53bd12e
apply criticalay patch + remove resolve confict artifacts
amoniaka-knabino Jul 13, 2026
69a3cff
null safe to attachFastScroller
amoniaka-knabino Jul 13, 2026
f2d0c71
apply criticalAY patch 2
amoniaka-knabino Jul 14, 2026
e414bf6
cache scroll offset and range
amoniaka-knabino Jul 14, 2026
b9fe9bd
add more comments
amoniaka-knabino Jul 14, 2026
9e1511c
add scroll calibration to make scroll in the end correct and smooth
amoniaka-knabino Jul 15, 2026
ffc4ff3
update only on content change, ignore itemrangechange (fixes scroll t…
amoniaka-knabino Jul 15, 2026
fea2103
fix dgrab&drag scroll jump
amoniaka-knabino Jul 16, 2026
55463a3
smaller border for end calibration
amoniaka-knabino Jul 16, 2026
8606f14
don't reset cache on card menu open
amoniaka-knabino Jul 19, 2026
178fd46
add comments
amoniaka-knabino Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,9 @@ class CardBrowserFragment :
toggleRowSelections.isVisible = inMultiSelect

// update adapter to remove check boxes
cardsAdapter.notifyDataSetChanged()
if (shouldRefreshBrowserRows(modeChange)) {
cardsAdapter.notifyDataSetChanged()
}
if (modeChange is SingleSelectCause.DeselectRow) {
cardsAdapter.notifyDataSetChanged()
autoScrollTo(modeChange.selection)
Expand Down Expand Up @@ -1875,6 +1877,17 @@ class PreviewerDestination(
val idsFile: IdsFile,
)

/**
* Opening the editor from single-select does not change row rendering, so a full adapter refresh
* would unnecessarily invalidate the fast scroller's cached metrics. A refresh is still needed
* when leaving multi-select to remove the selection UI.
*/
internal fun shouldRefreshBrowserRows(modeChange: ChangeMultiSelectMode): Boolean {
val singleSelectCause = modeChange as? SingleSelectCause ?: return true
return singleSelectCause != SingleSelectCause.OpenNoteEditorActivity ||
!singleSelectCause.previouslySelectedRowIds.isNullOrEmpty()
}

@CheckResult
fun PreviewerDestination.toIntent(context: Context) = PreviewerFragment.getIntent(context, idsFile, currentIndex)

Expand Down
2 changes: 2 additions & 0 deletions AnkiDroid/src/main/java/com/ichi2/anki/dialogs/tags/TagsDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import com.ichi2.anki.libanki.NoteId
import com.ichi2.anki.libanki.withCollapsedWhitespace
import com.ichi2.anki.model.CardStateFilter
import com.ichi2.anki.snackbar.showSnackbar
import com.ichi2.anki.ui.attachFastScroller
import com.ichi2.anki.utils.ext.requireParcelable
import com.ichi2.ui.AccessibleSearchView
import com.ichi2.utils.DisplayUtils.resizeWhenSoftInputShown
Expand Down Expand Up @@ -230,6 +231,7 @@ class TagsDialog : AnalyticsDialogFragment {

tagsArrayAdapter = TagsArrayAdapter(tags) { binding.root.showMaxTagSelectedNotice(tags) }
binding.tagsList.adapter = tagsArrayAdapter
binding.tagsList.attachFastScroller(R.id.tags_scroller)

@sanjaysargam sanjaysargam Jul 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is scroller ID is not found ? It may crash
worth adding a null safe

@amoniaka-knabino amoniaka-knabino Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thank you. I made attachFastScroller null safe

if (tags.isEmpty) {
binding.noTagsTextView.visibility = View.VISIBLE
}
Expand Down
Loading
Loading