-
Notifications
You must be signed in to change notification settings - Fork 113
1207 fix #1266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
1207 fix #1266
Changes from 18 commits
460169d
53b929b
98eca4f
75f1c44
951bb36
5b1611c
4dafb00
8d664c2
c1712d4
107d43a
ae1c36e
4f15dd9
7b6c07f
1a35326
f46e8d5
c85271f
ac1ecdf
1d0386d
7568d01
3a2a913
3f3f787
b726e4f
1f708c9
d20a84f
3d06425
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -139,6 +139,14 @@ int jdata::add_particle(real pmass, real pradius, | |
| real dt) // default = -1 | ||
| { | ||
| const char *in_function = "jdata::add_particle"; | ||
|
|
||
| if (pmass <= _TINY_) { | ||
| if (mpi_rank == 0) { | ||
| cerr << "Warning: ignoring particle with mass=" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this going to produce a line of output for every massless test particle? That could be a lot, and what does that add? After all, ignoring a particle with no mass won't make a difference to the result anyway.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point, let me remove that.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Addressed through commit 3a2a913. |
||
| << pmass << endl; | ||
| } | ||
| return -1; | ||
| } | ||
| if (DEBUG > 2 && mpi_rank == 0) PRL(in_function); | ||
|
|
||
| if (nj >= njbuf) { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is TINY ever not defined? If so, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_TINY_may not be defined if PH4 is not the running AMUSE code in which case the_TINY_definition in stdinc.h may be skipped: