Repository navigation
fix: apply control and power modifiers to Unitary in OpenQASM - #1367
Open
Iamsohungrynow wants to merge 1 commit into
Open
Iamsohungrynow wants to merge 1 commit into
Iamsohungrynow wants to merge 1 commit into
Conversation
Unitary._to_openqasm (src/braket/circuits/gates.py:3681) took control, control_state and power as **kwargs and never used them, so a modified Unitary was serialized as the bare matrix on its targets. On LocalSimulator, Unitary(X) on q1 controlled on q0 flipped q1 from |00>, and Unitary(X) with power=2 flipped |0>. The pragma takes no modifiers, so I fold them into the matrix: the power the same way to_unitary does, then the controlled block, with the control qubits listed before the targets. Circuit.unitary() still has no control argument; I left that alone.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1367 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 171 171
Lines 11667 11680 +13
Branches 1539 1541 +2
=========================================
+ Hits 11667 11680 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
none, found while checking how gate modifiers export to OpenQASM
Description of changes:
Unitary._to_openqasmignoredcontrol,control_stateandpower, so a controlledUnitary(X)dropped its control and flipped q1 from |00> onLocalSimulator. i fold the power and the controlled block into the pragma matrix, control qubits firstTesting done:
added
Unitarycases totest_gate_controlandtest_gate_powerplus a fractional power round trip, all failing on main. full unit suite passes at 100% coverage, ruff and mypy cleanMerge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.