Skip to content

fix: add a circuit validation test and github action - #361

Merged
AbeCoull merged 5 commits into
mainfrom
circuit_test
Apr 17, 2026
Merged

AbeCoull merged 5 commits into
mainfrom
circuit_test

Conversation

@AbeCoull

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:
adds in a circuit validation suite to github actions and tox

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AbeCoull AbeCoull changed the title Circuit test fix: add a circuit validation test and github action Apr 15, 2026
@codecov

codecov Bot commented Apr 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (dde04f3) to head (1991cb6).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #361   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         4771      4771           
  Branches       539       539           
=========================================
  Hits          4771      4771           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rmshaffer
rmshaffer self-requested a review April 16, 2026 00:27
Comment thread tox.ini Outdated
Comment thread .github/workflows/circuits-validation.yml Outdated
@AbeCoull
AbeCoull marked this pull request as ready for review April 16, 2026 14:48
@AbeCoull
AbeCoull requested a review from a team as a code owner April 16, 2026 14:48

@aniksd-braket aniksd-braket left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great extension to our testing capability. My one concern would be the time it would now take to run our CI tests, do you have any insights/metrics into that?

return c


def _measured_probabilities(ops, n_qubits):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we use result.measurement_probabilities in this function, and then filter out based on n_qubits

@rmshaffer

Copy link
Copy Markdown
Member

This is a great extension to our testing capability. My one concern would be the time it would now take to run our CI tests, do you have any insights/metrics into that?

They're actually run in this PR itself. Looks like the new integ-tests took only about 1 minute.

@AbeCoull
AbeCoull merged commit ab11ed6 into main Apr 17, 2026
29 checks passed
@AbeCoull
AbeCoull deleted the circuit_test branch April 17, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants