Repository navigation
Conversation
So that the tests of the address $A block are together.
There is no documented difference between 'contact' and 'address' blocks, besides the div class being 'contact' rather than 'address'. A practical difference is that the 'contact' block requires manual line breaks, either as trailing double spaces, or trailing double backslashes. The 'address' block does not require manual line breaks. This difference confuses users, and leads to rendered contact blocks having visible backslashes on the website. This commit changes the way that 'contact' blocks are treated, making it equivalent to 'address' blocks except that it omits the tag `<div class="adr org fn">`. This means that 'contact' blocks no longer require manual line breaks, but still support them as before. Tests of 'address' blocks have been duplicated and adapted to test 'contact' blocks. No existing tests have been meaningfully altered.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no documented difference between 'contact' and 'address' blocks, besides the div class being 'contact' rather than 'address'.
A practical difference is that the 'contact' block requires manual line breaks, either as trailing double spaces, or trailing double backslashes. The 'address' block does not require manual line breaks. This difference confuses users, and leads to rendered contact blocks having visible backslashes on the website.
This commit changes the way that 'contact' blocks are treated, making it equivalent to 'address' blocks except that it omits the tag
<div class="adr org fn">. This means that 'contact' blocks no longer require manual line breaks, but still support them as before.Tests of 'address' blocks have been duplicated and adapted to test 'contact' blocks. No existing tests have been meaningfully altered.