Don't delay daily tags for draft PRs - #1191
Draft
TimoWilken wants to merge 2 commits into
Draft
Conversation
TimoWilken
force-pushed
the
dont-wait-draft-prs
branch
from
September 22, 2022 09:40
119ec32 to
13da381
Compare
TimoWilken
marked this pull request as draft
September 22, 2022 09:53
TimoWilken
force-pushed
the
dont-wait-draft-prs
branch
from
September 22, 2022 09:54
4da6e3c to
c68087e
Compare
Contributor
Author
|
OK, seems to be working with the AliPhysics dailies. However, I've had to update to a newer PyGithub version (the older one we were using before doesn't expose a |
Member
|
No, we don't especially now that all new builds are done on cc7. |
TimoWilken
marked this pull request as ready for review
October 12, 2022 16:28
Contributor
Author
|
The fix to use only Python 3 is in #1206. |
Draft PRs are not tested until marked as non-draft, so there's no point in waiting for them.
TimoWilken
force-pushed
the
dont-wait-draft-prs
branch
from
October 20, 2022 12:08
c68087e to
b390765
Compare
Contributor
Author
|
@ktf CI is green now. Is this OK to merge? |
ktf
reviewed
Oct 20, 2022
| long_description = f.read() | ||
|
|
||
| install_requires = ['PyGithub==1.45', 'argparse', 'requests', 'pytz', 's3cmd', | ||
| install_requires = ['PyGithub==1.55', 'argparse', 'requests', 'pytz', 's3cmd', |
Member
There was a problem hiding this comment.
are you sure this works everywhere?
TimoWilken
marked this pull request as draft
December 18, 2023 14:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PRs are not tested until marked as non-draft, so there's no point in waiting for them.