Skip to content

fix(ruby): add more retry error details - #3384

Merged
millotp merged 5 commits into
mainfrom
fix/retry-error-ruby-client
Jul 23, 2024
Merged

fix(ruby): add more retry error details#3384
millotp merged 5 commits into
mainfrom
fix/retry-error-ruby-client

Conversation

@otomatik

@otomatik otomatik commented Jul 18, 2024

Copy link
Copy Markdown
Contributor

馃Л What and Why

馃師 JIRA Ticket: https://algolia.atlassian.net/browse/DASH-1649

Changes included:

  • adding more details when raising an exception after last retry end in error state

馃И Test

Tested in this similar PR: algolia/algoliasearch-client-ruby#501

@algolia-bot

algolia-bot commented Jul 18, 2024

Copy link
Copy Markdown
Contributor

鉁旓笍 Code generated!

Name Link
馃獡 Triggered by c54fd06d75dcfa194db20ea00bbdd466b96d9df3
馃崈 Generated commit 1765a00cde7b4503f788c0c8f71e8ea42112d844
馃尣 Generated branch generated/fix/retry-error-ruby-client
馃搳 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
ruby 874

@millotp millotp changed the title fix(error): add more retry error details fix(ruby): add more retry error details Jul 18, 2024
@otomatik otomatik self-assigned this Jul 18, 2024
@github-actions

github-actions Bot commented Jul 18, 2024

Copy link
Copy Markdown

Comment thread clients/algoliasearch-client-ruby/lib/algolia/transport/transport.rb Outdated
kombucha
kombucha previously approved these changes Jul 22, 2024

@kombucha kombucha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@otomatik
otomatik force-pushed the fix/retry-error-ruby-client branch from f70c4f0 to 5bd2870 Compare July 23, 2024 11:48
@otomatik
otomatik marked this pull request as ready for review July 23, 2024 12:29
@otomatik
otomatik requested a review from a team as a code owner July 23, 2024 12:29
@otomatik
otomatik requested review from millotp and shortcuts July 23, 2024 12:29
@millotp
millotp merged commit b0fa5a9 into main Jul 23, 2024
@millotp
millotp deleted the fix/retry-error-ruby-client branch July 23, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants