Skip to content

fix(import): preserve NeoDash markdown + auto-generate parameter widgets #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alfredo1996 merged 2 commits into from
Jun 4, 2026
Merged

fix(import): preserve NeoDash markdown + auto-generate parameter widgets #936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b67e54d
fix(import): preserve NeoDash markdown + auto-generate parameter widgets
alfredorubin96 Jun 4, 2026
dc30bd8
fix(import): address CR + Sonar findings on #936
alfredorubin96 Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/src/lib/__tests__/dashboard/neodash-converter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,9 @@ describe("convertNeoDash", () => {
query: "MATCH (n) WHERE n.name = $neodash_userName RETURN n",
}),
);
expect(result.layout.pages[0].widgets[0].query).toBe(
// Referencing $param_userName triggers a Filters page being prepended
// (auto-generated parameter-select for the undefined param). Original at index 1.
expect(result.layout.pages[1].widgets[0].query).toBe(
"MATCH (n) WHERE n.name = $param_userName RETURN n",
);
});
Expand Down Expand Up @@ -438,7 +440,8 @@ describe("convertNeoDash", () => {
"MATCH (n) WHERE n.name = $neodash_name AND n.age > $neodash_minAge RETURN n",
}),
);
expect(result.layout.pages[0].widgets[0].query).toBe(
// Two referenced params → Filters page prepended; original page at index 1.
expect(result.layout.pages[1].widgets[0].query).toBe(
"MATCH (n) WHERE n.name = $param_name AND n.age > $param_minAge RETURN n",
);
});
Expand Down
Loading
Loading