-
Notifications
You must be signed in to change notification settings - Fork 0
feat(enterprise): SSO OIDC providers — schema, API, auth flow #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6d413aa
feat(enterprise): SSO providers schema, API, OIDC auth flow (M1+M2)
alfredorubin96 6087c3c
feat(enterprise): Settings > Authentication admin page (M3)
alfredorubin96 4adc4ef
fix(a11y,e2e): add missing DialogDescription, fix E2E login flake
alfredorubin96 fd09dfd
feat(enterprise): Auth.js dynamic OIDC wiring + login page SSO button…
alfredorubin96 e354868
test(enterprise): E2E SSO flow with Keycloak Testcontainer (M5)
alfredorubin96 4579494
docs: add SSO configuration guide with IdP examples
alfredorubin96 fec8eda
feat(auth): env-based SSO config — single OIDC provider via env vars
alfredorubin96 268e1c3
feat(auth): support comma-separated values in SSO role mapping
alfredorubin96 62eeca8
docs: document comma-separated values in SSO role mapping
alfredorubin96 5b030cc
feat(auth): gate env-based SSO behind NEOBOARD_EDITION=enterprise
alfredorubin96 2f86db9
docs: fix SSO docs to consistently require NEOBOARD_EDITION=enterprise
alfredorubin96 d41f8be
docs: restructure documentation into topic-based sections (#705, #708)
alfredorubin96 62c52f6
fix(ci): update package-lock.json with enterprise workspace
alfredorubin96 9bc898a
fix(e2e): use exact match for 'Sign in' button in all E2E tests
alfredorubin96 56d6548
fix(e2e): update CORS test to match #689 security hardening
alfredorubin96 ecbe520
fix(auth,security): address CodeRabbit findings on PR #702
alfredorubin96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Paths excluded from the public mirror by sync-public.yml. | ||
| # Each line maps to a --path argument passed to git filter-repo --invert-paths. | ||
| # | ||
| # To add a new exclusion: | ||
| # 1. Add the path here | ||
| # 2. Add a matching --path line in .github/workflows/sync-public.yml | ||
| enterprise/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| name: Sync to Public Mirror | ||
|
|
||
| # This workflow runs in the PRIVATE repo (neoboard-private) and pushes | ||
| # a filtered copy (without enterprise/) to the public repo (neoboard). | ||
| # | ||
| # Required secret: PUBLIC_REPO_TOKEN — a GitHub PAT with repo push access | ||
| # to alfredo1996/neoboard. | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main, dev] | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| sync: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout private repo (full history) | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Install git-filter-repo | ||
| run: pip install git-filter-repo | ||
|
|
||
| - name: Remove enterprise/ from history | ||
| run: | | ||
| git filter-repo \ | ||
| --force \ | ||
| --invert-paths \ | ||
| --path enterprise/ | ||
|
|
||
| - name: Push to public mirror | ||
| run: | | ||
| git remote add public \ | ||
| https://x-access-token:${{ secrets.PUBLIC_REPO_TOKEN }}@github.com/alfredo1996/neoboard.git | ||
| git push public HEAD:refs/heads/${{ github.ref_name }} --force | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| CREATE TYPE "public"."sso_protocol" AS ENUM('oidc');--> statement-breakpoint | ||
| CREATE TABLE "sso_provider" ( | ||
| "id" text PRIMARY KEY NOT NULL, | ||
| "tenant_id" text DEFAULT 'default' NOT NULL, | ||
| "name" text NOT NULL, | ||
| "protocol" "sso_protocol" DEFAULT 'oidc' NOT NULL, | ||
| "issuer" text NOT NULL, | ||
| "client_id" text NOT NULL, | ||
| "client_secret_encrypted" text NOT NULL, | ||
| "scopes" text DEFAULT 'openid profile email' NOT NULL, | ||
| "claim_mappings" jsonb, | ||
| "auto_provision" boolean DEFAULT true NOT NULL, | ||
| "default_role" "user_role" DEFAULT 'creator' NOT NULL, | ||
| "enforce_sso" boolean DEFAULT false NOT NULL, | ||
| "enabled" boolean DEFAULT true NOT NULL, | ||
| "created_at" timestamp DEFAULT now(), | ||
| "updated_at" timestamp DEFAULT now(), | ||
| CONSTRAINT "sso_provider_tenant_issuer_unique" UNIQUE("tenant_id","issuer") | ||
| ); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set explicit least-privilege workflow permissions.
This job doesn’t define
permissions, so it inherits repo/org defaults. For a mirror sync job, explicitly pin permissions to reduce accidental token overreach.Suggested patch
on: push: branches: [main, dev] workflow_dispatch: +permissions: + contents: read + jobs: sync: runs-on: ubuntu-latestAs per coding guidelines "CI workflows: check for secret exposure, unnecessary permissions, and that coverage is generated before any SonarQube scan step."
🤖 Prompt for AI Agents