Skip to content

chore(demo): add circle-packing and choropleth to chart gallery (#570) - #630

Merged
alfredo1996 merged 5 commits into
release/2.0from
chore/issue-570-demo-missing-charts
May 1, 2026
Merged

chore(demo): add circle-packing and choropleth to chart gallery (#570)#630
alfredo1996 merged 5 commits into
release/2.0from
chore/issue-570-demo-missing-charts

Conversation

@alfredo1996

@alfredo1996 alfredo1996 commented Apr 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add circle-packing and choropleth pages to the demo Chart Gallery showcase
  • Chart Gallery now covers all 20 registered chart types (was 18/20)
  • Circle Packing: top 25 products by revenue using ecommerce data
  • Choropleth Map: customer distribution by country using regions table
  • Each page includes a markdown explainer describing the chart and options

Test plan

  • JSON validates correctly (20 pages, all chart types represented)
  • neoboard demo seed --only=chart-gallery reseeds with new pages
  • Circle packing renders with product data
  • Choropleth renders with country data

Closes #570

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Gantt visualization added to Chart Gallery for timeline views of product order items with aggregated start/end handling.
    • Circle Packing visualization added for revenue aggregation of top products with configurable labels, padding, and enhanced color palettes.
    • Choropleth Map visualization introduced for geographic customer counts with interactive zoom/pan and continuous color scaling.

Add two missing chart type pages to the demo Chart Gallery showcase,
bringing coverage from 18/20 to 20/20 registered chart types.

- Circle Packing: top 25 products by revenue, nested circles
- Choropleth Map: customer distribution by country, world map

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 04deabd7-d06d-44be-9754-a56dcbbd88c8

📥 Commits

Reviewing files that changed from the base of the PR and between f0c1ca7 and 67c2bc1.

📒 Files selected for processing (4)
  • app/e2e/global-setup.ts
  • app/src/plugins/index.ts
  • scripts/demo/chart-gallery.json
  • scripts/demo/import-dashboard.mjs
✅ Files skipped from review due to trivial changes (2)
  • scripts/demo/import-dashboard.mjs
  • app/src/plugins/index.ts

Walkthrough

Updates demo assets and startup/import validation: modifies scripts/demo/chart-gallery.json (gantt query rewrite; adds Circle Packing and Choropleth pages), expands known chart types in the demo import validator, swaps a connector-types source in plugin startup validation, and tweaks the Next.js build flag used in E2E global setup.

Changes

Cohort / File(s) Summary
Chart Gallery JSON
scripts/demo/chart-gallery.json
Rewrites Gantt query to use a derived subquery (aggregated order-item dates, computed start/end with ROW_NUMBER), and adds two new pages: Circle Packing (top-25 revenue aggregation + label/padding/palette) and Choropleth Map (distinct customers by country + roam/continuous color range).
Demo import validator
scripts/demo/import-dashboard.mjs
Adds "gantt", "circle-packing", and "choropleth" to the semantic allowlist for widget.chartType so those widgets pass second-pass validation.
Plugin startup validation
app/src/plugins/index.ts
Changes the source module used to build KNOWN_CONNECTORS for validating each plugin's compatibleWith entries (same validation logic, different import/source).
E2E global setup
app/e2e/global-setup.ts
Adjusts the Next.js production build invocation to include --webpack when running npx next build during Playwright global setup.
Manifest / other
scripts/demo/chart-gallery.json (manifest impact)
Net +75/-1 lines reflecting added pages and query edits in the demo manifest JSON.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

area:charts

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title correctly summarizes the main change: adding circle-packing and choropleth chart types to the demo chart gallery.
Linked Issues check ✅ Passed The PR delivers Circle Packing and Choropleth chart types to Chart Gallery [#570], progressing from 18/20 toward the goal of covering all 20 registered chart types with realistic data examples.
Out of Scope Changes check ✅ Passed All changes are scoped to chart-gallery.json additions, connector validation imports, E2E build flags, and demo validation allowlist—all directly supporting the two new chart implementations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/issue-570-demo-missing-charts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

alfredorubin96 and others added 3 commits April 29, 2026 13:50
Two fixes:
1. Import CONNECTOR_TYPES from @neoboard/connection/connector-types
   sub-path instead of the barrel export. The barrel unconditionally
   imports connector-registry → PostgresConnectionModule → pg, which
   requires Node.js tls module unavailable in the client bundle.
2. Add --webpack flag to E2E global-setup build command to match the
   project's build config and produce BUILD_ID for skip-build caching.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The seed script validation rejected these chart types added in
release/2.0. Update the allowlist so demo seeding succeeds.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…o allowlist

- Gantt seed query: wrap in subquery, cast dates to text for proper
  JSON serialization, use MIN(created_at) with ROW_NUMBER() window
- Add gantt, circle-packing, choropleth to KNOWN_CHART_TYPES in
  import-dashboard.mjs validation allowlist

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented May 1, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants