chore(demo): add circle-packing and choropleth to chart gallery (#570) - #630
Conversation
Add two missing chart type pages to the demo Chart Gallery showcase, bringing coverage from 18/20 to 20/20 registered chart types. - Circle Packing: top 25 products by revenue, nested circles - Choropleth Map: customer distribution by country, world map Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
WalkthroughUpdates demo assets and startup/import validation: modifies Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Two fixes: 1. Import CONNECTOR_TYPES from @neoboard/connection/connector-types sub-path instead of the barrel export. The barrel unconditionally imports connector-registry → PostgresConnectionModule → pg, which requires Node.js tls module unavailable in the client bundle. 2. Add --webpack flag to E2E global-setup build command to match the project's build config and produce BUILD_ID for skip-build caching. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The seed script validation rejected these chart types added in release/2.0. Update the allowlist so demo seeding succeeds. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…o allowlist - Gantt seed query: wrap in subquery, cast dates to text for proper JSON serialization, use MIN(created_at) with ROW_NUMBER() window - Add gantt, circle-packing, choropleth to KNOWN_CHART_TYPES in import-dashboard.mjs validation allowlist Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|



Summary
Test plan
neoboard demo seed --only=chart-galleryreseeds with new pagesCloses #570
🤖 Generated with Claude Code
Summary by CodeRabbit