-
Notifications
You must be signed in to change notification settings - Fork 0
feat(component): add reference lines (markLine) for bar and line charts #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0672191
feat(component): add reference lines (markLine) for bar and line charts
alfredorubin96 a58b1cf
fix(ci): add missing ECharts component mocks for CI
alfredorubin96 675f7e9
fix: implement markLine for LineChart, add buildMarkLineFromRefs tests
alfredorubin96 e4fcf26
fix(e2e): use keyboard fallback when CM6 editor reports readonly
alfredorubin96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import { describe, it, expect } from "vitest"; | ||
| import { parseReferenceLines } from "../chart-utils"; | ||
| import type { ReferenceLine } from "../chart-utils"; | ||
|
|
||
| describe("parseReferenceLines", () => { | ||
| it("returns empty array for undefined input", () => { | ||
| expect(parseReferenceLines(undefined)).toEqual([]); | ||
| }); | ||
|
|
||
| it("returns empty array for empty string", () => { | ||
| expect(parseReferenceLines("")).toEqual([]); | ||
| }); | ||
|
|
||
| it("parses a single horizontal reference line", () => { | ||
| const input = JSON.stringify([{ value: 50, label: "Target", color: "#ff0000" }]); | ||
| const result = parseReferenceLines(input); | ||
| expect(result).toHaveLength(1); | ||
| expect(result[0]).toEqual({ value: 50, label: "Target", color: "#ff0000" }); | ||
| }); | ||
|
|
||
| it("parses multiple reference lines", () => { | ||
| const input = JSON.stringify([ | ||
| { value: 25, label: "Low" }, | ||
| { value: 75, label: "High", color: "#00ff00" }, | ||
| ]); | ||
| const result = parseReferenceLines(input); | ||
| expect(result).toHaveLength(2); | ||
| }); | ||
|
|
||
| it("returns empty array for invalid JSON", () => { | ||
| expect(parseReferenceLines("not-json")).toEqual([]); | ||
| }); | ||
|
|
||
| it("filters out entries without a value", () => { | ||
| const input = JSON.stringify([{ label: "No value" }, { value: 50, label: "OK" }]); | ||
| const result = parseReferenceLines(input); | ||
| expect(result).toHaveLength(1); | ||
| expect(result[0].value).toBe(50); | ||
| }); | ||
| }); | ||
|
|
||
| describe("ReferenceLine type", () => { | ||
| it("accepts minimal reference line", () => { | ||
| const line: ReferenceLine = { value: 100 }; | ||
| expect(line.value).toBe(100); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue
#136requires vertical lines support.The acceptance criteria states "Support both horizontal and vertical lines." Current implementation only supports horizontal lines (
yAxispositioning inbuildMarkLineFromRefs).Consider adding an
axisordirectionfield toReferenceLineto supportxAxispositioning for vertical lines.🤖 Prompt for AI Agents