chore: untrack tsconfig.tsbuildinfo and ignore local launch.json (#1241) - #1242
Conversation
The TypeScript incremental-build cache was tracked, so every build dirtied the working tree and got swept into unrelated commits by git add -A (it polluted both #1238 and #1239 and had to be reverted by hand). - ignore *.tsbuildinfo and untrack app/tsconfig.tsbuildinfo - ignore .claude/launch.json (per-developer local config, previously untracked-but-not-ignored, i.e. the same accident waiting to happen) - app/next-env.d.ts stays TRACKED on purpose: the CI typecheck job runs tsc --noEmit with no prior next build, so nothing regenerates it there. Documented inline so it does not get 'tidied' away later. Verified: tsc --noEmit passes for app and component, and the working tree stays clean after a type-check run. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 8 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
2 participants
Closes #1241.
Problem
app/tsconfig.tsbuildinfo— a TypeScript incremental-build cache — was tracked in git. Every build dirtied the working tree, sogit add -Asilently swept it into unrelated commits. It polluted both #1238 and #1239 during the v1.4 work and had to be reverted by hand each time..claude/launch.json(per-developer local config) was untracked but not ignored: the same accident waiting to happen.Changes
*.tsbuildinfo, untrackapp/tsconfig.tsbuildinfo.claude/launch.jsonapp/next-env.d.tsstays tracked on purpose, with the reason recorded inline in.gitignoreThe one risky part, investigated first
The obvious instinct is to ignore
next-env.d.tstoo, since Next.js generates it. That would break CI. Thetypecheckjob inci.ymlruns:with no prior
next buildornext dev— so nothing regenerates the file in CI, andtscwould lose Next's ambient types. It therefore stays tracked, and.gitignorecarries a comment explaining why so a future cleanup doesn't remove it.Verification
tsc --noEmitpasses for bothappandcomponent— confirms keepingnext-env.d.tswas correct.git statusis clean after a type-check run (the acceptance signal from the issue); previously this left a modifiedtsconfig.tsbuildinfo..gitignoremodified,app/tsconfig.tsbuildinfodeleted. No source files touched, so no test changes are warranted.Out of scope
No history rewrite. Removing the file going forward is sufficient; purging it from history on a public repo would be far more disruptive than the problem.
🤖 Generated with Claude Code