Миграция со старых жизненных методов в Select - #1152
Open
kdmatrosov wants to merge 3 commits into
Open
Conversation
kdmatrosov
commented
May 6, 2020
| @@ -1,3 +1,4 @@ | |||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | |||
Contributor
Author
There was a problem hiding this comment.
После merge из master (+ rm -rf node_modules и npm i) linter стал ругаться (кидать error) на require, не давая сделать commit.
Поставил ignore пока.
Вопрос: как такой вариант настройки линтера с ошибками проник в мастер? @prosto-lapsha
По идее же не только у меня должно ругаться на webpack и gulpfile
Contributor
There was a problem hiding this comment.
я за фижуром так пристально не смотрю) я за прайватои приглядываю, поэтому не могу дать ответ на этот вопрос
Contributor
There was a problem hiding this comment.
Странно, у меня только ворнинги
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Обновлен Select
Мотивация и контекст
#911