Skip to content

fix(fly-io): restore Machines patches after /v1 spec-mirror prefix #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mkassabov wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(fly-io): restore Machines patches after /v1 spec-mirror prefix #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48ba536
fix(fly-io): apply /v1 OpenAPI patches before generated specs
Mkassabov Sep 1, 2026
4b784fb
feat(codegen): verbNoun operation names in OpenAPI convert
Mkassabov Sep 1, 2026
8a6eec1
refactor(codegen): apply patches in convert, not generate
Mkassabov Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .agents/skills/distilled-sdk/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,22 @@ Iterate on `convert.ts` (spec → Smithy) and `generate.ts` (Smithy → TS)
separately: `pnpm --filter @distilled.cloud/<pkg> run convert` stops after the
Smithy models, which is usually where the interesting bugs are.

Patches go in `packages/<pkg>/patches/` as RFC-6902 `*.patch.json` and apply
to the **OpenAPI document**, before conversion. A package that patches there
passes `patchesDir: false` to `runGeneratorCli` so the Smithy-model patch
chain stays off. Patch the spec, not the generated TypeScript.
Patches go in `packages/<pkg>/patches/` as RFC-6902 `*.json` and apply in
**convert**, so `.generated-specs` is the patched Smithy model. OpenAPI
pointers (`/paths`, `/components`) run on the spec before conversion;
Smithy pointers (`/shapes`, `/metadata`) run on the model after. generate
does not patch — it only compiles the committed models.
**Stale patch pointers fail the run** (they used to warn-and-skip, which is
how Fly's whole chain vanished after the spec-mirror prefixed paths with
`/v1`). Pass `onStalePatch: "warn"` only if you truly want skip.

Operation **names** are convert policy, not patches. Pass
`operationNaming: "verbNoun"` on `runOpenApiConvert` so go-swagger
`Apps_list` / `Apps_show` become `listApps` / `getApp` in the Smithy model
(and the SDK). Irregulars go in `operationNames` (lookup by `"METHOD path"`,
then operationId) — PUT vs PATCH that share an upstream id need the path
key. Do not RFC-6902-patch `/paths/~1foo/get/operationId`; those break when
upstream adds a prefix. Patch the spec, not the generated TypeScript.

## Step 6 — wire the submodule

Expand Down
Loading
Loading