fix(pr-package): keep PR previews until the pull request closes - #1511
Merged
Conversation
TTL expiry now checks GitHub when a tarball is tagged with Alchemy-Pull-Request and renews while the PR is open. CI binds that header after publish, deletes the preview on close, and updates the sticky install comment.
Contributor
|
Preview packages for this PR have been removed. The install URLs from this comment no longer resolve. Older per-commit URLs expire with their TTL. |
Closing one PR could release tags another open PR still claimed on the same content-addressed tarball. Tags are now recorded per PR; a closed PR releases only tags no other open PR claims. GitHub lookups accept a bound GITHUB_TOKEN and unverifiable PRs stop renewing after 28 days. Use actions#12 so the publish action sends Alchemy-Pull-Request itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview packages used to vanish when their 1-week TTL fired, even if the PR was still open.
Tag assignment now accepts
Alchemy-Pull-Request: owner/repo#123. On TTL expiry the Durable Object checks GitHub and renews while any tied PR is open. A closed PR releases only the tags that were assigned with that PR and that no other open PR also claims, so a content-addressed tarball shared withmainor with another PR pinning the same commit is left alone.pullRequests: { "owner/repo#n": { tags, verifiedAt } })GITHUB_TOKENat deploy time binds a token for the PR lookups; a PR GitHub cannot confirm keeps renewing for at most 28 days after it was last seen openclosed, and rewrites the sticky install commentpr-packageunit tests run incheck.yml