fix(cloudflare): make vite main authoritative over an app-declared entry input - #1410
Open
filipfalcon wants to merge 1 commit into
Open
fix(cloudflare): make vite main authoritative over an app-declared entry input#1410filipfalcon wants to merge 1 commit into
filipfalcon wants to merge 1 commit into
Conversation
…try input Vite folds every plugin's `config` result into the config the next plugin sees, so the entry input this plugin returns is unioned with an input the app's own plugins declared for the same environment. A framework that names its own server entry — Foldkit's `ssr.build`, for one — left two entry chunks in the bundle, and the deployed Worker became whichever one the bundle listed first: the framework's server entry rather than the module `main` names. That Worker exports no handler, and nothing warned. Rewrite the entry environment's input from the per-environment `options` hook, which runs after config resolution, where nothing merges over it. Only when `main` is set, and only for the entry environment — children keep the entries their framework gave them.
Contributor
|
It's not clear to me what problem this solves and why a blanket solution is the correct approach? Can you elaborate? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vite folds every plugin's
configresult into the config the next plugin sees, so the entry input this plugin returns is unioned with an input the app's own plugins declared for the same environment. A framework that names its own server entry — Foldkit'sssr.build, for one — left two entry chunks in the bundle, and the deployed Worker became whichever one the bundle listed first: the framework's server entry rather than the modulemainnames. That Worker exports no handler, and nothing warned.Rewrite the entry environment's input from the per-environment
optionshook, which runs after config resolution, where nothing merges over it. Only whenmainis set, and only for the entry environment — children keep the entries their framework gave them.