fix(cloudflare/workers): provide workerd-safe runtime services - #1403
Open
harrysolovay wants to merge 1 commit into
Open
fix(cloudflare/workers): provide workerd-safe runtime services#1403harrysolovay wants to merge 1 commit into
harrysolovay wants to merge 1 commit into
Conversation
Contributor
|
Can you provide a reproduction? I am confused about this error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NodeServices.layerwith the specific Node platform services supported by workerd, excludingNodeTerminalNodeChildProcessSpawner.layerwithFileSystemandPathviaLayer.provideMergeso its requirements are satisfiedAlchemy.Stageservice fromstack.stageBackground
NodeServices.layerinitializesNodeTerminal, which callsprocess.stdin.once(...). Cloudflare's Node compatibility shim does not implement.once(), so Worker startup failed witht.once is not a functionbefore the user handler ran.Simply merging the remaining platform layers as siblings is insufficient because
Layer.mergeAlldoes not use sibling outputs to satisfy sibling requirements. In particular,NodeChildProcessSpawner.layerrequiresFileSystemandPath, which led toService not found: effect/platform/FileSystem. This change retains dependency-aware composition while omitting the unsupported terminal service.Verification
pnpm install --frozen-lockfilereached the repository prepare step, which could not find the uninitializeddistilled/packages/cloudflaresubmodule in the fresh clone