Repository navigation
Conversation
|
|
||
| ## Goal | ||
|
|
||
| Restore a trustworthy Angular 22 validation baseline for `@nebular/theme`: all theme unit tests pass, ESLint runs with Angular ESLint 22, and fixes preserve Nebular's public behavior rather than weakening tests. |
There was a problem hiding this comment.
these files will be deleted after review and making other fixes in this pr
|
@denStrigo @elupanov can you check this out, please. I would like to upgrade this version because my project requires Nebular and I want this package be compatible with latest Angular. |
|
Hi @40oleg |
Run the Angular 22 Nebular demo on Windows 11Open PowerShell as Administrator and install Git and NVM for Windows: winget install --id Git.Git --exact
winget install --id CoreyButler.NVMforWindows --exactClose PowerShell and open it again. Install the required Node.js version: nvm install 22.22.3
nvm use 22.22.3
node --version
Clone the PR branch and start the component playground: git clone --branch feat/angular-22 https://github.com/40oleg/nebular.git
cd nebular
npm ci
npm startOpen http://localhost:4200/. The first page is a component index. A styled example is available at http://localhost:4200/#/button/button-showcase.component. To run the documentation site, open another PowerShell window in the npm run docs:serveOpen http://localhost:4100/. Press Input something in search field to components` list become visible |
|
Hi @40oleg . When I do it with thе current changes I see those errors in the terminal: Could you please check what is wrong with the code? |
There was a problem hiding this comment.
should we drop all the committed AI planning docs from the PR?
| platform: NbPlatform, | ||
| ngZone: NgZone, | ||
| protected ruler: NbLayoutRulerService, | ||
| protected scroll: NbLayoutScrollService, | ||
| @Inject(NB_DOCUMENT) document: any, |
There was a problem hiding this comment.
keeps dead constructor params (platform, ngZone, document) now unused since super() takes none. Drop them (same for the Inject/NgZone/NbPlatform/NB_DOCUMENT imports) to match the scroll-dispatcher cleanup?
There was a problem hiding this comment.
curious, why this index loses half its links? either the generator is broken on ng22 (skips components) or a partial tree was committed? should we try regenerate from a clean tree?
Completed the Nebular migration to Angular 22: