Skip to content

feat: BB datacenter/server support#6128

Draft
fuskovic wants to merge 19 commits into
mainfrom
fuskovic/bb-client
Draft

feat: BB datacenter/server support#6128
fuskovic wants to merge 19 commits into
mainfrom
fuskovic/bb-client

Conversation

@fuskovic

@fuskovic fuskovic commented Apr 20, 2026

Copy link
Copy Markdown
Member

Closes: #6020

Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
@fuskovic fuskovic self-assigned this Apr 20, 2026
@netlify

netlify Bot commented Apr 20, 2026

Copy link
Copy Markdown

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 1778923
🔍 Latest deploy log https://app.netlify.com/projects/docs-kargo-io/deploys/6a1ffdaa65fee80007ba683a
😎 Deploy Preview https://deploy-preview-6128.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fuskovic fuskovic added area/external-providers Related to external API providers kind/enhancement An entirely new feature priority/low Low commitment from maintainers; progress is likely to be community-driven labels Apr 20, 2026
@codecov

codecov Bot commented Apr 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.62846% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.54%. Comparing base (4afa565) to head (1778923).
⚠️ Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
pkg/gitprovider/bitbucket/datacenter/provider.go 97.62% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6128      +/-   ##
==========================================
+ Coverage   58.30%   58.54%   +0.24%     
==========================================
  Files         500      501       +1     
  Lines       41925    42178     +253     
==========================================
+ Hits        24444    24693     +249     
- Misses      16012    16015       +3     
- Partials     1469     1470       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread Makefile Outdated
Comment thread Makefile
Comment thread pkg/gitprovider/bitbucket/cloud/zz_bitbucket_cloud_client.gen.go
@krancour

Copy link
Copy Markdown
Member

I think there are some things to discuss here still, but I am really happy to see that generating a BB client and using that appears tenable.

@krancour krancour added this to the v1.11.0 milestone Apr 20, 2026
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
@fuskovic fuskovic changed the title feat: BB merge strategies + OAPI client generation feat: BB client gen (for cloud + server) + merge strategy support Apr 24, 2026
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
@fuskovic

Copy link
Copy Markdown
Member Author

@krancour so far we are able to:

  1. Remove github.com/ktrysmt/go-bitbucket
  2. Support Datacenter/Server
  3. Support alternative merge strategies for both

This obviously needs a lot of end-to-end testing.

Per our offline discussion I have sub-packages:

  • pkg/gitprovider/bitbucket/cloud
  • pkg/gitprovider/bitbucket/datacenter

Implemented each with their own individual registration predicate.

@fuskovic

Copy link
Copy Markdown
Member Author

I can take this out of draft and start end-to-end testing unless there's something else we still want to discuss?

@fuskovic fuskovic requested a review from krancour April 24, 2026 15:55
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
@fuskovic fuskovic changed the title feat: BB client gen (for cloud + server) + merge strategy support feat: BB client gen (for cloud + datacenter/server) + merge strategy support May 8, 2026
@fuskovic

Copy link
Copy Markdown
Member Author

To unblock non-server/datacenter work, bb cloud client gen and alt merge strategy support have been moved into a separate PR here.

Will leave this open for now in the event we are unblocked on testing the datacenter path in the future.

Signed-off-by: fuskovic <fhuskovic92@gmail.com>
@fuskovic fuskovic changed the title feat: BB client gen (for cloud + datacenter/server) + merge strategy support feat: BB datacenter/server support Jun 3, 2026
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
@thomastaylor312 thomastaylor312 removed this from the v1.11.0 milestone Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/external-providers Related to external API providers kind/enhancement An entirely new feature priority/low Low commitment from maintainers; progress is likely to be community-driven

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add support for opening, waiting on, and merging Bitbucket Data Center (nee Server) PRs

3 participants