Skip to content

build(COMPASS-28): move to js-yaml 5 and ajv-formats 3 #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
timdawborn wants to merge 1 commit into from
Draft

build(COMPASS-28): move to js-yaml 5 and ajv-formats 3 #2721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/src/validation-server/verifications/contract-mismatcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import JsonSchemaValidator from "ajv";
import Ajv from "ajv-formats";
import addFormats from "ajv-formats";
import assertNever from "assert-never";
import qs from "qs";
import * as url from "url";
Expand Down Expand Up @@ -413,7 +413,8 @@ export class ContractMismatcher {
return [];
}

const jsv = Ajv(
// `addFormats` adds the format validators to the instance and returns it.
const jsv = addFormats(
new JsonSchemaValidator({
verbose: true,
allErrors: true
Expand Down
5 changes: 2 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@
"@oclif/help": "^1.0.15",
"@oclif/plugin-help": "^3.2.3",
"ajv": "^8.18.0",
"ajv-formats": "^2.1.1",
"ajv-formats": "^3.0.1",
"assert-never": "^1.4.0",
"cors": "^2.8.5",
"eslint": "^10.8.1",
"eslint-config-prettier": "^10.1.8",
"express": "^4.19.2",
"fs-extra": "^11.4.0",
"inquirer": "^8.1.1",
"js-yaml": "^4.3.1",
"js-yaml": "^5.2.3",
"prettier": "^3.9.6",
"qs": "^6.15.3",
"randomstring": "^1.3.1",
Expand All @@ -39,7 +39,6 @@
"@types/fs-extra": "^11.0.4",
"@types/inquirer": "^8.1.2",
"@types/jest": "^30.0.0",
"@types/js-yaml": "^4.0.9",
"@types/node": "^22.20.1",
"@types/qs": "^6.15.1",
"@types/randomstring": "^1.3.0",
Expand Down
36 changes: 24 additions & 12 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ overrides:
strictDepBuilds: true
blockExoticSubdeps: true
minimumReleaseAge: 10080
minimumReleaseAgeExclude: "@airtasker/*"
# A list, not a string: pnpm reads a scalar here as no exclusions and stops applying
# minimumReleaseAge at all, so the quarantine above silently covers nothing.
minimumReleaseAgeExclude:
- "@airtasker/*"
allowBuilds:
core-js: false
# Reached through jest-resolve. Its postinstall only fetches a native binding when
Expand Down
Loading