Skip to content

🧪 tools/dumping: run integration tests nightly - #7476

Open
GeigerJ2 wants to merge 1 commit into
aiidateam:mainfrom
GeigerJ2:test/enable-dumping-integration-tests
Open

🧪 tools/dumping: run integration tests nightly#7476
GeigerJ2 wants to merge 1 commit into
aiidateam:mainfrom
GeigerJ2:test/enable-dumping-integration-tests

Conversation

@GeigerJ2

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The dumping integration test module is marked with pytest.mark.nightly, restricting the entire module to nightly CI execution.

Changes

Dumping integration test scheduling

Layer / File(s) Summary
Mark integration tests for nightly CI
tests/tools/dumping/test_integration.py
Adds a module-level pytestmark assigning the nightly marker to all tests in the file.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so there is no meaningful description to assess. Add a brief description of the nightly-only test change and any related context.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: moving tools/dumping integration tests to nightly-only CI.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@GeigerJ2
GeigerJ2 marked this pull request as ready for review July 22, 2026 08:47
@GeigerJ2

Copy link
Copy Markdown
Collaborator Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

`tests/tools/dumping/integration_tests.py` (26 tests, added in aiidateam#6723)
matches neither of pytest's default `python_files` patterns
(`test_*.py`, `*_test.py`), and nothing overrides them, so directory
recursion never collected it. CI runs `pytest tests/`, so the whole
suite has been silently skipped since it landed on 2025-06-06.

Rename it to `test_integration.py` so the default collection finds it,
and mark the module `nightly` so the slow, DB-heavy dumps run only in
the nightly workflow rather than on every matrix job. No content
changes; all 26 pass, including under parallel (`-n auto`) and
randomized ordering.
@GeigerJ2
GeigerJ2 force-pushed the test/enable-dumping-integration-tests branch from d6ebba1 to 87beb89 Compare July 22, 2026 08:48
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.61%. Comparing base (42e5953) to head (87beb89).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7476      +/-   ##
==========================================
- Coverage   80.62%   80.61%   -0.01%     
==========================================
  Files         581      581              
  Lines       46802    46802              
==========================================
- Hits        37731    37724       -7     
- Misses       9071     9078       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant