Skip to content

v3.80.1: signed in is not allowed (security) - #18

Merged
agit8or1 merged 1 commit into
mainfrom
security/3.80.1-role-gates
Nov 9, 2026
Merged

agit8or1 merged 1 commit into
mainfrom
security/3.80.1-role-gates

Conversation

@agit8or1

@agit8or1 agit8or1 commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Security release; see the advisory GHSA-r7xj-q84q-rpwc (to be published with this release) and CHANGELOG.md.

  • Every state-changing page/endpoint now checks a capability, not only a login (tests/role_gate_test.php enforces it in CI).
  • api/run_diagnostic.php and api/network_diagnostic.php no longer build shell text from unvalidated input.
  • First agent claim of an unbound firewall is tied to a redeemed enrolment token.
  • Secure defaults when settings rows are absent (raw shell off, admin MFA required); new Settings > Security Policy card; master-key banner.

Behaviour changes for upgraders are in docs/UPGRADING.md under 3.80.1.

Tests: every tests/*_test.php passes against opnsense_fw_test, including the new role_gate_test, role_gate_behaviour_test and secure_defaults_test.

🤖 Generated with Claude Code

Security release. Many endpoints checked a login but not a role.

- api/run_diagnostic.php: remote command was inside a double-quoted local
  shell string, so $(...) in a target ran on the manager as www-data. Now
  one escaped ssh argument, strict parameter validation, command.diagnostic.
- api/network_diagnostic.php: target interpolated into a root shell script
  behind FILTER_VALIDATE_DOMAIN only. Now built by the structured catalogue.
- add_user.php: any signed-in user could create an admin. user.manage.
- api/queue_action.php: every action needs risk_to_capability(risk).
- api/trigger_update.php: update.install, audit-logged.
- 20 more state-changing pages gated on their matrix capability;
  tests/role_gate_test.php enforces this in CI.
- First agent claim of an unbound firewall needs an enrolment token
  redeemed for it within agent_claim_window_hours (default 24); unadopted
  credentials are re-sent only within that window.
- Missing settings rows now mean raw shell off and admin MFA required;
  raw_commands_enabled() fails closed. New Settings > Security Policy card.
- Admin banner while OPNMGR_MASTER_KEY is unset; create_admin.php
  generates the key.

Advisory: GHSA-r7xj-q84q-rpwc

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@agit8or1
agit8or1 merged commit a690783 into main Nov 9, 2026
10 checks passed
@agit8or1
agit8or1 deleted the security/3.80.1-role-gates branch November 9, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants