Repository navigation
v3.80.1: signed in is not allowed (security) - #18
Merged
Merged
Conversation
Security release. Many endpoints checked a login but not a role. - api/run_diagnostic.php: remote command was inside a double-quoted local shell string, so $(...) in a target ran on the manager as www-data. Now one escaped ssh argument, strict parameter validation, command.diagnostic. - api/network_diagnostic.php: target interpolated into a root shell script behind FILTER_VALIDATE_DOMAIN only. Now built by the structured catalogue. - add_user.php: any signed-in user could create an admin. user.manage. - api/queue_action.php: every action needs risk_to_capability(risk). - api/trigger_update.php: update.install, audit-logged. - 20 more state-changing pages gated on their matrix capability; tests/role_gate_test.php enforces this in CI. - First agent claim of an unbound firewall needs an enrolment token redeemed for it within agent_claim_window_hours (default 24); unadopted credentials are re-sent only within that window. - Missing settings rows now mean raw shell off and admin MFA required; raw_commands_enabled() fails closed. New Settings > Security Policy card. - Admin banner while OPNMGR_MASTER_KEY is unset; create_admin.php generates the key. Advisory: GHSA-r7xj-q84q-rpwc Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security release; see the advisory GHSA-r7xj-q84q-rpwc (to be published with this release) and
CHANGELOG.md.tests/role_gate_test.phpenforces it in CI).api/run_diagnostic.phpandapi/network_diagnostic.phpno longer build shell text from unvalidated input.Behaviour changes for upgraders are in
docs/UPGRADING.mdunder 3.80.1.Tests: every
tests/*_test.phppasses againstopnsense_fw_test, including the newrole_gate_test,role_gate_behaviour_testandsecure_defaults_test.🤖 Generated with Claude Code