Skip to content

v3.79.3: don't lose bandwidth results over a CPU figure - #16

Merged
agit8or1 merged 1 commit into
mainfrom
fix/speedtest-cpu-overflow
Nov 7, 2026
Merged

agit8or1 merged 1 commit into
mainfrom
fix/speedtest-cpu-overflow

Conversation

@agit8or1

@agit8or1 agit8or1 commented Nov 7, 2026

Copy link
Copy Markdown
Owner

The first 32-stream test on the datacenter firewall measured 4,980 Mbps down (3× the old ceiling), but the result was never stored. iperf3 reports host_total CPU summed across its threads; this run reported 625%, which overflowed a TINYINT UNSIGNED column, so the insert failed.

  • Migration 0033 widens the two CPU columns to SMALLINT UNSIGNED.
  • Values are clamped to their column before insert.
  • A storage error is logged and no longer fails the command result. The raw result is always kept in firewall_commands.result.
  • The "may be CPU-limited" flag is now judged per stream instead of on the summed figure.

Tests: tests/speedtest_test.php 36 passed. Full suite: 72 files, 2,973 passed, 0 failed.

🤖 Generated with Claude Code

iperf3 sums CPU across threads (625% on a 32-stream run on the 40-core
datacenter firewall); that overflowed TINYINT UNSIGNED and the 4,980 Mbps
measurement was lost. SMALLINT columns (migration 0033), clamped values, and
a storage error no longer fails the command result. CPU-limited is judged
per stream.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@agit8or1
agit8or1 merged commit 78303ef into main Nov 7, 2026
5 checks passed
@agit8or1
agit8or1 deleted the fix/speedtest-cpu-overflow branch November 7, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants