Repository navigation
Clean up failed native registrations and verify onboarding - #1
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one native tool fails to register, earlier registrations can remain active when a browser only supports AbortSignal cleanup. Give the adapter its own registration lifetime and abort all registrations on failure or unmount, while retaining older unregisterTool cleanup.
Update both Next.js apps to 16.3.6, clarify fresh-checkout build/typecheck prerequisites, and use an ESM Vitest config. CI now runs the dashboard in its actual Compose container and requires real native WebMCP support.
Validation: CI run 36952837796 passed all 16 unit tests, production builds, the authenticated browser journey, 13 integration checks, independent SDK installation, PostgreSQL restart/restore/upgrade/retention, owner recovery, the workload boundary check and dependency audit. Flagged Chromium 153.0.8010.12 executed all three dashboard tools, visibly changed filters, rejected unauthorized project reads, and persisted seven native storefront events with success, failure and cancellation outcomes. Sign-out removed all dashboard tools. Local frozen install, typecheck and both app builds also passed.