Skip to content

cmake: mark the Homebrew include path SYSTEM so it cannot shadow vendored headers #5399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jensenpat merged 2 commits into from
Sep 6, 2026
Merged

cmake: mark the Homebrew include path SYSTEM so it cannot shadow vendored headers #5399

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c3d531
cmake: mark the Homebrew include path SYSTEM so it cannot shadow vend…
on8st Sep 3, 2026
00bc3d7
Correct Homebrew header collision examples. Principle VIII.
jensenpat Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,17 @@ if(APPLE)
execute_process(COMMAND brew --prefix OUTPUT_VARIABLE HOMEBREW_PREFIX OUTPUT_STRIP_TRAILING_WHITESPACE)
if(HOMEBREW_PREFIX)
link_directories("${HOMEBREW_PREFIX}/lib")
include_directories("${HOMEBREW_PREFIX}/include")
# SYSTEM is load-bearing, not cosmetic. A plain include_directories()
# here is directory-scoped at the TOP level, so it is inherited by every
# add_subdirectory() and initialises every target's INCLUDE_DIRECTORIES
# ahead of whatever that target adds for itself -- which means
# /opt/homebrew/include outranks every vendored include dir in the tree.
# Any Homebrew formula whose headers share a basename with a vendored one
# then silently wins, reversing the choice USE_SYSTEM_* made in CMake:
# ggml.h, whisper.h and fftw3.h are all shadowed on a stock dev machine.
Comment thread
jensenpat marked this conversation as resolved.
Outdated
# SYSTEM emits -isystem, which the compiler searches AFTER all -I paths,
# so Homebrew stays findable and stops taking precedence.
include_directories(SYSTEM "${HOMEBREW_PREFIX}/include")
endif()
endif()

Expand Down
Loading