Repository navigation
checks: The sweep's box test is possibly_within's own - #52
Merged
Merged
Conversation
`pairs_within` wrote out `Outline::possibly_within`'s box test a second time, and its unit test a third: a change to one would leave the sweep reading pairs differently from every other caller, unnoticed. The test is `geom::boxes_within` now, used by all three. The dense fixture's comment had the extra cut's two gaps the wrong way round - 0.05 - drop is above the row, 0.05 + drop below the next - and the dense cases check that S.dense leaves the Inner extras alone and S.dense.pair the Cut ones. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pairs_withinwrote outOutline::possibly_within's box test a second time, and its unit test a third: a change to one would leave the sweep reading pairs differently from every other caller, unnoticed. The test isgeom::boxes_withinnow, used by all three.The dense fixture's comment had the extra cut's two gaps the wrong way round - 0.05 - drop is above the row, 0.05 + drop below the next - and the dense cases check that S.dense leaves the Inner extras alone and S.dense.pair the Cut ones.