fix(ci): pass required --system-prompt to engineer-bot author phase - #642
Merged
Conversation
The author step invoked `engineer_bot.run --phase author --bot .bot` without `--system-prompt`. Engine #89 made that argument required and removed the built-in default, so the pinned engine (ENGINE_REF d05dcb1) now exits 2 with "the following arguments are required: --system-prompt" before any fix work runs — failing every issue-triggered engineer-bot fix. The followup workflow was updated for engine #89 but the author step in this workflow was missed. Point it at the author system prompt in .bot/prompts/engineer/system.md, mirroring engineer-bot-followup.yml. Co-authored-by: Isaac
eric-wang-1990
requested review from
gopalldb,
lidavidm,
msrathore-db and
vikrantpuppala
as code owners
August 11, 2026 16:05
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
Engine #89 requires the author phase to receive BOTH --system-prompt (argparse-required) and --user-prompt (enforced in run.py main()). This repo's .bot/config.yaml has no author.build_user_prompt hook and renders .bot/prompts/engineer/user.md via author.env_tokens, so --user-prompt is mandatory. Passing only --system-prompt clears the argparse error but the run would still SystemExit at the user-prompt check. Mirror the engine's canonical engineer-bot.yml, which passes both. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engineer-bot Fix workflow fails at the "Run bug-fix author" step for every issue-triggered run:
Root cause
engineer-bot.yamlinvoked the author phase with the pre-#89 CLI form:Engine #89 externalized the prompts out of the engine. The author phase now requires both:
--system-prompt PATH— argparse-required=True(this is the arg that produced theexit 2above).--user-prompt PATH— required for the author phase, enforced inrun.pymain()(rendered as a template, filling{{issue_*}}fromauthor.env_tokensin.bot/config.yaml).All bot workflows are pinned to
ENGINE_REF d05dcb1, which includes #89. The followup workflow was updated for it; the author step here was missed. This breaks every issue-triggered engineer-bot fix, e.g. run 31474456965 on #640.Fix
Pass both prompt paths, mirroring the engine's own canonical
engineer-bot.yml:Both files already exist in this repo.
--flowis intentionally omitted —.bot/config.yamlsetsflow: bug-fixas the default.This pull request and its description were written by Isaac.