feat(csharp): wire telemetry for SEA/REST protocol connections - #432
Closed
eric-wang-1990 wants to merge 1 commit into
Closed
feat(csharp): wire telemetry for SEA/REST protocol connections#432eric-wang-1990 wants to merge 1 commit into
eric-wang-1990 wants to merge 1 commit into
Conversation
eric-wang-1990
requested review from
gopalldb,
lidavidm,
msrathore-db and
vikrantpuppala
as code owners
April 30, 2026 22:51
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
eric-wang-1990
force-pushed
the
fix/peco-3010-sea-telemetry-wiring
branch
from
April 30, 2026 23:06
add91b0 to
d8eb950
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SeaConnectionTelemetryimplementingIConnectionTelemetryfor the REST protocol, with aCreate()factory that mirrorsConnectionTelemetry.Create()but uses session ID string (no Thrift handle) and emitsDriverMode.SeaStatementExecutionConnection.OpenAsync()after session creation; telemetry is flushed/released onDispose()StatementExecutionStatementfor bothExecuteQueryAsyncandExecuteUpdateAsync, matching theDatabricksStatement(Thrift) implementationTODO: PECO-3010comments from telemetry E2E test files now that SEA telemetry is wiredJira
Fixes PECO-3010
Test plan
TelemetryBaselineTests,AuthTypeTests,ClientTelemetryE2ETests, etc.)ChunkDetailsTelemetryTests,ConnectionParametersTests,RetryCountTests) continue to skip forrestprotocol🤖 Generated with Claude Code