Skip to content

feat(csharp): wire telemetry for SEA/REST protocol connections - #432

Closed
eric-wang-1990 wants to merge 1 commit into
mainfrom
fix/peco-3010-sea-telemetry-wiring
Closed

feat(csharp): wire telemetry for SEA/REST protocol connections#432
eric-wang-1990 wants to merge 1 commit into
mainfrom
fix/peco-3010-sea-telemetry-wiring

Conversation

@eric-wang-1990

Copy link
Copy Markdown
Collaborator

Summary

  • Created SeaConnectionTelemetry implementing IConnectionTelemetry for the REST protocol, with a Create() factory that mirrors ConnectionTelemetry.Create() but uses session ID string (no Thrift handle) and emits DriverMode.Sea
  • Wired telemetry initialization in StatementExecutionConnection.OpenAsync() after session creation; telemetry is flushed/released on Dispose()
  • Statement-level telemetry (execute latency, result format, chunk metrics, error info) is emitted per-statement in StatementExecutionStatement for both ExecuteQueryAsync and ExecuteUpdateAsync, matching the DatabricksStatement (Thrift) implementation
  • Removed 7 TODO: PECO-3010 comments from telemetry E2E test files now that SEA telemetry is wired

Jira

Fixes PECO-3010

Test plan

  • Build succeeds without errors
  • Telemetry events are emitted for SEA connections (verified by TelemetryBaselineTests, AuthTypeTests, ClientTelemetryE2ETests, etc.)
  • Thrift-only telemetry tests (ChunkDetailsTelemetryTests, ConnectionParametersTests, RetryCountTests) continue to skip for rest protocol

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@eric-wang-1990
eric-wang-1990 force-pushed the fix/peco-3010-sea-telemetry-wiring branch from add91b0 to d8eb950 Compare April 30, 2026 23:06
@eric-wang-1990

Copy link
Copy Markdown
Collaborator Author

Superseded by the telemetry rework that landed — esp. #460 (protocol-agnostic ConnectionTelemetry) plus #437/#438/#517. Reopen if a SEA/REST telemetry gap remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant