Skip to content

perf: widen simple-absolute http(s) parse fast path #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anonrig wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf: widen simple-absolute http(s) parse fast path #1199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97a8c69
perf: widen simple-absolute http(s) parse fast path
anonrig Jul 31, 2026
68e3d77
ci: use PRE_TEST gtest discovery on Windows
anonrig Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/implementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,9 @@ std::optional<bool> try_can_parse_absolute_fast(
template <class result_type>
ada_warn_unused tl::expected<result_type, errors> parse(
std::string_view input, const result_type* base_url) {
// Single try_parse lives inside parse_url_impl. Do not call try_parse here
// as well: IPv4/IPv6 (and other non-simple) inputs would pay the fast-path
// reject twice and show large CodSpeed regressions on those benches.
result_type u = ada::parser::parse_url_impl<result_type>(input, base_url);
if (!u.is_valid) {
return tl::unexpected(errors::type_error);
Expand Down
Loading
Loading