Skip to content

Missing test coverage for encode_json for values smaller than 0x1f #516

Description

@Uzlopak

What is the problem this feature will solve?

increases test coverage

What is the feature you are proposing to solve the problem?

I was investigating ada. I saw that you do 2 * c and was wondering if a bitshift makes a difference c << 1 but then I realized that if replace with just returning '0', then ctest --output-on-failure --test-dir build will pass all the tests. So there is missing test coverage.

I guess that the compiler will create the same bytecode for 2 * c and c << 1. But it would make sense to have test coverage.

What alternatives have you considered?

No response

Activity

  1. anonrig commented on Sep 27, 2023

    @anonrig
    Member

    Would you like to open a pull request for the missing test?

  2. Uzlopak commented on Sep 27, 2023

    @Uzlopak
    Author

    I have no clue where to put it :D

  3. anonrig commented on Oct 10, 2023

    @anonrig
    Member

    I have no clue where to put it :D

    test/basic_tests.cpp works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions