Skip to content

Fix misleading error/debug messages in run-container-step.ts #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikola-jokic merged 3 commits into from
Jun 5, 2026
Merged

Fix misleading error/debug messages in run-container-step.ts #370

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d53abd2
Initial plan
Copilot Jun 4, 2026
dde2f7f
Fix misleading error messages in run-container-step.ts
Copilot Jun 4, 2026
00e14d6
Merge origin/main and resolve run-container-step conflict
Copilot Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/k8s/src/hooks/run-container-step.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ export async function runContainerStep(
pod = await createContainerStepPod(getStepPodName(), container, extension)
} catch (err) {
const message = formatError(err)
core.debug(`createJob failed: ${message}`)
throw new Error(`failed to run script step: ${message}`)
core.debug(`createContainerStepPod failed: ${message}`)
throw new Error(`failed to run container step: ${message}`)
}

if (!pod.metadata?.name) {
Expand Down Expand Up @@ -112,7 +112,7 @@ export async function runContainerStep(
} catch (err) {
const message = formatError(err)
core.debug(`execPodStep failed: ${message}`)
throw new Error(`failed to run script step: ${message}`)
throw new Error(`failed to run container step: ${message}`)
} finally {
fs.rmSync(runnerPath, { force: true })
}
Expand Down
Loading